Target & Verify action should append to Jira labels, not overwrite. #3588
Conversation
|
Tested by adding a label to the JIRA issue, then running Target & Verify, and checking that "WasNextFeasible" was appended instead of overwriting the existing label. |
|
|
|
@Naatan ping |
Naatan
left a comment
Naatan
left a comment
There was a problem hiding this comment.
I thought it would only update based on the fields provided. If it empties anything that's not provided then this may also affect other fields. Would perhaps a more robust fix be to assign all fields, and then update FixVersions? Right now it seems like anything but FixVersions and Labels might get pruned.
|
The concern you raised may look problematic based on the diff GitHub shows, but the troublesome line is here: https://github.com/ActiveState/cli/pull/3588/files#diff-2224e300e5d1da6fa67f6cf4cfc1d6b288f60bda27d6d0181bce500076850273R192. We need to initialize the struct with the current set of labels if we want to append to it. Otherwise, we're appending to an empty list, which will overwrite the current label. I think we're fine. |
Ahh ok, that makes sense. Thanks for explaining! |
Uh oh!
There was an error while loading. Please reload this page.